Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: traffic light position #12366

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

feat: traffic light position #12366

wants to merge 2 commits into from

Conversation

FabianLars
Copy link
Member

closes #4789

Copy link
Contributor

Package Changes Through ba941fa

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@alterhuman
Copy link

Hey, new to Tauri, been waiting for this to merge since a week. Is there a blocker for it to not be merged? Thanks.

@FabianLars
Copy link
Member Author

my motivation was/is the main blocker tbh.

the pr didn't actually got delayed though, i always had 2.3 in mind at the earliest and PRs for that are yet to be merged (aiming for a patch release before that on the weekend).

you can test this already as long as you don't create your windows in js because i didn't add those apis yet. simply add this to your Cargo.toml and run cargo update tauri in your src-tauri dir

[patch.crates-io]
tauri = { git = "https://github.com/tauri-apps/tauri", branch = "traffic-lights-offset" }

If you do that, please report back whether you have issues or if it works fine (will accelerate the merge :P)

@alterhuman
Copy link

I tried to run it but the cli is not allowing adding "trafficLightPosition" in conf.json. Sorry new here, maybe I'm missing something obvious.

@FabianLars
Copy link
Member Author

Ah right, my bad. For the config option you'll also need the CLI from git (the rust Apis should work without)

cargo install tauri-cli --debug --git https://github.com/tauri-apps/tauri --branch traffic-lights-offset

And then you'll use cargo tauri dev instead of npm run tauri dev or whatever you use atm.

@alterhuman
Copy link

Have updated CLI:

src-tauri git:(main) ✗ cargo install tauri-cli --debug --git https://github.com/tauri-apps/tauri --branch traffic-lights-offset

Updating git repository `https://github.com/tauri-apps/tauri`
Ignored package `tauri-cli v2.2.4 (https://github.com/tauri-apps/tauri?branch=traffic-lights-offset#ba941fa6)` is already installed, use --force to override

Still getting same error.
Error while using cargo tauri dev

unknown field `trafficLightPosition`, 
expected one of `label`, `create`, `url`, `user-agent`, `userAgent`, `drag-drop-enabled`...
found an unknown configuration field. 
This usually means that you are using a CLI version that is newer than `tauri-build` and is incompatible.
Please try updating the Rust crates by running `cargo update` in the Tauri app folder.

Have tried cargo clean and then update as well. It's probably still using

This is react + vite.

@alterhuman
Copy link

Figured it out, had to also override tauri-build

[patch.crates-io]
tauri-build = { git = "https://github.com/tauri-apps/tauri", branch = "traffic-lights-offset" }
tauri = { git = "https://github.com/tauri-apps/tauri", branch = "traffic-lights-offset" }

It's working. Will revert after testing.

@alterhuman
Copy link

No issues found, it's working correctly.

@FabianLars
Copy link
Member Author

coolio, thanks for testing!

@tr3ysmith
Copy link
Contributor

@FabianLars looking forward to this!! any updates on when it'll merge?

@FabianLars
Copy link
Member Author

🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Allowing for native inset OS X traffic lights on NSWindow
3 participants